netdev - Re: [PATCH net] cls_rsvp: fix rsvp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200201123240.04f871d3@cakuba.hsd1.ca.comcast.net>
Date:   Sat, 1 Feb 2020 12:32:40 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Cong Wang <xiyou.wangcong@...il.com>,
        Eric Dumazet <edumazet@...gle.com>
Cc:     "David S . Miller" <davem@...emloft.net>,
        netdev <netdev@...r.kernel.org>,
        Eric Dumazet <eric.dumazet@...il.com>,
        syzbot <syzkaller@...glegroups.com>
Subject: Re: [PATCH net] cls_rsvp: fix rsvp_policy

On Sat, 1 Feb 2020 11:21:55 -0800, Cong Wang wrote:
> On Fri, Jan 31, 2020 at 3:27 PM 'Eric Dumazet' via syzkaller
> <syzkaller@...glegroups.com> wrote:
> >
> > NLA_BINARY can be confusing, since .len value represents
> > the max size of the blob.
> >
> > cls_rsvp really wants user space to provide long enough data
> > for TCA_RSVP_DST and TCA_RSVP_SRC attributes.  
> 
> To clarify: for NLA_UNSPEC (0), len is the minimum length.

Nice clarification, that makes the patch obvious.

Looks like we have NLA_MIN_LEN now, from Wireguard, but I understand
for backports it's easier to stick to the original way of handling 
this.

Applied, thank you!