netdev - Re: [PATCH 1/6] netfilter: ipset: fix suspicious RCU usage in find_set_and

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 1 Feb 2020 20:21:50 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Jozsef Kadlecsik <kadlec@...filter.org>
Cc:     Pablo Neira Ayuso <pablo@...filter.org>, Greg KH <greg@...ah.com>,
        Stephen Rothwell <sfr@...b.auug.org.au>,
        netfilter-devel@...r.kernel.org,
        David Miller <davem@...emloft.net>, netdev@...r.kernel.org
Subject: Re: [PATCH 1/6] netfilter: ipset: fix suspicious RCU usage in
 find_set_and_id

On Sat, 1 Feb 2020 22:11:04 +0100 (CET), Jozsef Kadlecsik wrote:
> On Sat, 1 Feb 2020, Jakub Kicinski wrote:
> > On Sat, 1 Feb 2020 12:57:36 -0800, Jakub Kicinski wrote:  
> > > On Fri, 31 Jan 2020 20:24:23 +0100, Pablo Neira Ayuso wrote:  
> > > > From: Kadlecsik József <kadlec@...ckhole.kfki.hu>
> > > > 
> > > > find_set_and_id() is called when the NFNL_SUBSYS_IPSET mutex is held.
> > > > However, in the error path there can be a follow-up recvmsg() without
> > > > the mutex held. Use the start() function of struct netlink_dump_control
> > > > instead of dump() to verify and report if the specified set does not
> > > > exist.
> > > > 
> > > > Thanks to Pablo Neira Ayuso for helping me to understand the subleties
> > > > of the netlink protocol.
> > > > 
> > > > Reported-by: syzbot+fc69d7cb21258ab4ae4d@...kaller.appspotmail.com
> > > > Signed-off-by: Jozsef Kadlecsik <kadlec@...filter.org>
> > > > Signed-off-by: Pablo Neira Ayuso <pablo@...filter.org>    
> > > 
> > > This will trigger a missing signed-off-by check:
> > > 
> > > Commit 5038517119d5 ("netfilter: ipset: fix suspicious RCU usage in find_set_and_id")
> > > 	author Signed-off-by missing
> > > 	author email:    kadlec@...ckhole.kfki.hu
> > > 	committer email: pablo@...filter.org
> > > 	Signed-off-by: Jozsef Kadlecsik <kadlec@...filter.org>
> > > 	Signed-off-by: Pablo Neira Ayuso <pablo@...filter.org>
> > > 
> > > Problem is that the name differs by 'o' vs 'ó' (József Kadlecsik).
> > > 
> > > I wonder if it's worth getting rid of diacritics for the comparison..  
> > 
> > Mm.. also the name and surname are the other way around :S  
> 
> Oh, my... Hungarian names... :-) But I also should set my sender email 
> address to kadlec@...filter.org.
> 
> What's the best approach for this patch? Shall I resend it?

This one is in David Miller's tree already so too late, just fix up
your setup going forward please.

To a fellow Central European Jozsef Kadlecsik and Kadlecsik József 
are more than interchangeable, but probably not worth teaching the
validation scripts about this.