netdev - Re: [PATCH 2/6] net: bcmgenet: refactor phy mode configuration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 2 Feb 2020 19:24:20 -0800
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Andrew Lunn <andrew@...n.ch>
Cc:     Jeremy Linton <jeremy.linton@....com>, netdev@...r.kernel.org,
        opendmb@...il.com, davem@...emloft.net,
        bcm-kernel-feedback-list@...adcom.com,
        linux-kernel@...r.kernel.org, wahrenst@....net,
        hkallweit1@...il.com
Subject: Re: [PATCH 2/6] net: bcmgenet: refactor phy mode configuration



On 2/2/2020 5:17 PM, Andrew Lunn wrote:
> On Sat, Feb 01, 2020 at 08:24:14AM -0800, Florian Fainelli wrote:
>>
>>
>> On 1/31/2020 11:46 PM, Jeremy Linton wrote:
>>> The DT phy mode is similar to what we want for ACPI
>>> lets factor it out of the of path, and change the
>>> of_ call to device_. Further if the phy-mode property
>>> cannot be found instead of failing the driver load lets
>>> just default it to RGMII.
>>
>> Humm no please do not provide a fallback, if we cannot find a valid
>> 'phy-mode' property we error out. This controller can be used with a
>> variety of configurations (internal EPHY/GPHY, MoCA, external
>> MII/Reverse MII/RGMII) and from a support perspective it is much easier
>> for us if the driver errors out if one of those essential properties are
>> omitted.
> 
> Hi Florian
> 
> Does any of the silicon variants have two or more MACs sharing one
> MDIO bus? I'm thinking about the next patch in the series.

Have not come across a customer doing that, but the hardware
definitively permits it, and so does the top-level chip pinmuxing.
-- 
Florian