lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 3 Feb 2020 10:20:46 +0000 (GMT) From: "Maciej W. Rozycki" <macro@...ux-mips.org> To: Dan Carpenter <dan.carpenter@...cle.com> cc: Christophe JAILLET <christophe.jaillet@...adoo.fr>, Ralf Baechle <ralf@...ux-mips.org>, "David S. Miller" <davem@...emloft.net>, Andrew Morton <akpm@...ux-foundation.org>, netdev@...r.kernel.org, linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org Subject: Re: [PATCH] defxx: Fix a sentinel at the end of a 'eisa_device_id' structure On Mon, 3 Feb 2020, Dan Carpenter wrote: > > diff --git a/drivers/net/fddi/defxx.c b/drivers/net/fddi/defxx.c > > index 077c68498f04..7ef0c57f07c6 100644 > > --- a/drivers/net/fddi/defxx.c > > +++ b/drivers/net/fddi/defxx.c > > @@ -3768,11 +3768,11 @@ static void dfx_pci_unregister(struct pci_dev *pdev) > > > > #ifdef CONFIG_EISA > > static const struct eisa_device_id dfx_eisa_table[] = { > > - { "DEC3001", DEFEA_PROD_ID_1 }, > > - { "DEC3002", DEFEA_PROD_ID_2 }, > > - { "DEC3003", DEFEA_PROD_ID_3 }, > > - { "DEC3004", DEFEA_PROD_ID_4 }, > > - { } > > + { "DEC3001", DEFEA_PROD_ID_1 }, > > + { "DEC3002", DEFEA_PROD_ID_2 }, > > + { "DEC3003", DEFEA_PROD_ID_3 }, > > + { "DEC3004", DEFEA_PROD_ID_4 }, > > + { "" } > > You haven't changed runtime at all. :P (struct eisa_device_id)->sig[] > is an array, not a pointer. There is no NULL dereference because an > array in the middle of another array can't be NULL. Right, the code is good as it stands (I should have more faith in my past achievements ;) ). Except for the whitespace issue, which I suppose might not be worth bothering to fix. Thanks for your meticulousness! Maciej
Powered by blists - more mailing lists