netdev - Re: [RFC] can: can_create_echo_skb(): fix echo skb generation: always use skb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 3 Feb 2020 14:52:54 +0100
From:   Marc Kleine-Budde <mkl@...gutronix.de>
To:     Naresh Kamboju <naresh.kamboju@...aro.org>,
        Oleksij Rempel <o.rempel@...gutronix.de>
Cc:     dev.kurt@...dijck-laurijssen.be, Netdev <netdev@...r.kernel.org>,
        lkft-triage@...ts.linaro.org, linux-can@...r.kernel.org,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        wg@...ndegger.com
Subject: Re: [RFC] can: can_create_echo_skb(): fix echo skb generation: always
 use skb_clone()

On 2/3/20 2:48 PM, Marc Kleine-Budde wrote:
>>> WARNING: CPU: 0 PID: 293 at lib/refcount.c:25 refcount_warn_saturate+0x108/0x174
>>> refcount_t: addition on 0; use-after-free.
>>
>> FYI,
>> This issue noticed in our Linaro test farm
>> On linux next version 5.5.0-next-20200203 running on beagleboard x15 arm device.
>>
>> Thanks for providing fix for this case.

Please look closely at your backtraces, they are totally unrelated. It
seems the whole culprit in your testcase fails with:

> [    0.000000] OF: ERROR: Bad of_node_put() on /ocp/interconnect@...00000/segment@...arget-module@...0/cm_core@...4per-cm@...0/l4per-clkctrl@28

...the rest are subsequent faults.

> Can we add your Tested-by to the patch?

Answering myself: NO!

Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |