netdev - Re: [PATCH 02/15] devlink: add functions to take snapshot while locked

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <356f9f89-5069-4853-a273-49913ba8fc5a@intel.com>
Date:   Mon, 3 Feb 2020 08:45:06 -0800
From:   Jacob Keller <jacob.e.keller@...el.com>
To:     Jiri Pirko <jiri@...nulli.us>
Cc:     netdev@...r.kernel.org, valex@...lanox.com, linyunsheng@...wei.com,
        lihong.yang@...el.com
Subject: Re: [PATCH 02/15] devlink: add functions to take snapshot while
 locked

On 2/3/2020 3:39 AM, Jiri Pirko wrote:
> Thu, Jan 30, 2020 at 11:58:57PM CET, jacob.e.keller@...el.com wrote:
>> + */
>> +static int
>> +devlink_region_snapshot_create_locked(struct devlink_region *region,
> 
> __devlink_region_snapshot_create()
> 

Yep, was pointed out earlier, will clean up in v2.

>> 	return id;
>> @@ -7622,7 +7679,7 @@ EXPORT_SYMBOL_GPL(devlink_region_snapshot_id_get);
>>  *	devlink_region_snapshot_create - create a new snapshot
>>  *	This will add a new snapshot of a region. The snapshot
>>  *	will be stored on the region struct and can be accessed
>> - *	from devlink. This is useful for future	analyses of snapshots.
>> + *	from devlink. This is useful for future analyses of snapshots.
> 
> What this hunk is about? :O
> 
> 

Not sure, but if I had to guess it was a stray space vs. tab thing that
accidentally got changed without reason.

Thanks,
Jake