netdev - Re: [PATCH net] net: sgi: ioc3-eth: Remove leftover free

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200204.144243.914260869258980952.davem@davemloft.net>
Date:   Tue, 04 Feb 2020 14:42:43 +0100 (CET)
From:   David Miller <davem@...emloft.net>
To:     tbogendoerfer@...e.de
Cc:     ralf@...ux-mips.org, paulburton@...nel.org,
        linux-mips@...r.kernel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH net] net: sgi: ioc3-eth: Remove leftover free_irq()

From: Thomas Bogendoerfer <tbogendoerfer@...e.de>
Date: Tue, 4 Feb 2020 12:58:33 +0100

> On Tue, 04 Feb 2020 12:44:55 +0100 (CET)
> David Miller <davem@...emloft.net> wrote:
> 
>> From: Thomas Bogendoerfer <tbogendoerfer@...e.de>
>> Date: Tue,  4 Feb 2020 12:36:28 +0100
>> 
>> > Commit 0ce5ebd24d25 ("mfd: ioc3: Add driver for SGI IOC3 chip") moved
>> > request_irq() from ioc3_open into probe function, but forgot to remove
>> > free_irq() from ioc3_close.
>> > 
>> > Fixes: 0ce5ebd24d25 ("mfd: ioc3: Add driver for SGI IOC3 chip")
>> > Signed-off-by: Thomas Bogendoerfer <tbogendoerfer@...e.de>
>> 
>> ioc3_open() still has the request_irq() in my tree.
> 
> then I guess you don't have commit 0ce5ebd24d25 in your tree. My Patch is
> against linus/master, where it is already applied. Should I rebase against your
> net tree, when the commit shows up ?

I just sync'd with Linus's tree so you should be able to rebase right now.

Thanks.