netdev - memory leak in tcindex_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <0000000000009a59d2059dc3c8e9@google.com>
Date:   Tue, 04 Feb 2020 09:58:13 -0800
From:   syzbot <syzbot+f0bbb2287b8993d4fa74@...kaller.appspotmail.com>
To:     davem@...emloft.net, jhs@...atatu.com, jiri@...nulli.us,
        kuba@...nel.org, linux-kernel@...r.kernel.org,
        netdev@...r.kernel.org, syzkaller-bugs@...glegroups.com,
        xiyou.wangcong@...il.com
Subject: memory leak in tcindex_set_parms

Hello,

syzbot found the following crash on:

HEAD commit:    322bf2d3 Merge branch 'for-5.6' of git://git.kernel.org/pu..
git tree:       upstream
console output: https://syzkaller.appspot.com/x/log.txt?x=1111f8e6e00000
kernel config:  https://syzkaller.appspot.com/x/.config?x=8d0490614a000a37
dashboard link: https://syzkaller.appspot.com/bug?extid=f0bbb2287b8993d4fa74
compiler:       gcc (GCC) 9.0.0 20181231 (experimental)
syz repro:      https://syzkaller.appspot.com/x/repro.syz?x=17db90f6e00000
C reproducer:   https://syzkaller.appspot.com/x/repro.c?x=13a94511e00000

IMPORTANT: if you fix the bug, please add the following tag to the commit:
Reported-by: syzbot+f0bbb2287b8993d4fa74@...kaller.appspotmail.com

executing program
executing program
BUG: memory leak
unreferenced object 0xffff88811ee18c00 (size 256):
  comm "syz-executor278", pid 7255, jiffies 4294941828 (age 13.710s)
  hex dump (first 32 bytes):
    00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00  ................
    00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00  ................
  backtrace:
    [<0000000004705b10>] kmemleak_alloc_recursive include/linux/kmemleak.h:43 [inline]
    [<0000000004705b10>] slab_post_alloc_hook mm/slab.h:586 [inline]
    [<0000000004705b10>] slab_alloc mm/slab.c:3320 [inline]
    [<0000000004705b10>] kmem_cache_alloc_trace+0x145/0x2c0 mm/slab.c:3549
    [<000000005a926de7>] kmalloc include/linux/slab.h:556 [inline]
    [<000000005a926de7>] kmalloc_array include/linux/slab.h:597 [inline]
    [<000000005a926de7>] kcalloc include/linux/slab.h:609 [inline]
    [<000000005a926de7>] tcf_exts_init include/net/pkt_cls.h:210 [inline]
    [<000000005a926de7>] tcindex_set_parms+0xac/0x970 net/sched/cls_tcindex.c:313
    [<000000004198237d>] tcindex_change+0xd8/0x110 net/sched/cls_tcindex.c:519
    [<00000000f90be4e9>] tc_new_tfilter+0x566/0xf50 net/sched/cls_api.c:2103
    [<00000000bdffab68>] rtnetlink_rcv_msg+0x3b2/0x4b0 net/core/rtnetlink.c:5429
    [<000000008de6f6fa>] netlink_rcv_skb+0x61/0x170 net/netlink/af_netlink.c:2477
    [<00000000637db501>] rtnetlink_rcv+0x1d/0x30 net/core/rtnetlink.c:5456
    [<00000000cb1396a7>] netlink_unicast_kernel net/netlink/af_netlink.c:1302 [inline]
    [<00000000cb1396a7>] netlink_unicast+0x223/0x310 net/netlink/af_netlink.c:1328
    [<000000003d9f7439>] netlink_sendmsg+0x2c0/0x570 net/netlink/af_netlink.c:1917
    [<0000000004922ee9>] sock_sendmsg_nosec net/socket.c:652 [inline]
    [<0000000004922ee9>] sock_sendmsg+0x54/0x70 net/socket.c:672
    [<00000000bbc6917f>] ____sys_sendmsg+0x2d0/0x300 net/socket.c:2343
    [<00000000d3ae3854>] ___sys_sendmsg+0x8a/0xd0 net/socket.c:2397
    [<0000000000c5372b>] __sys_sendmsg+0x80/0xf0 net/socket.c:2430
    [<00000000db15859a>] __do_sys_sendmsg net/socket.c:2439 [inline]
    [<00000000db15859a>] __se_sys_sendmsg net/socket.c:2437 [inline]
    [<00000000db15859a>] __x64_sys_sendmsg+0x23/0x30 net/socket.c:2437
    [<00000000a5a1c036>] do_syscall_64+0x73/0x220 arch/x86/entry/common.c:294
    [<00000000e73613df>] entry_SYSCALL_64_after_hwframe+0x44/0xa9

BUG: memory leak
unreferenced object 0xffff88811ee18900 (size 256):
  comm "syz-executor278", pid 7255, jiffies 4294941828 (age 13.710s)
  hex dump (first 32 bytes):
    00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00  ................
    00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00  ................
  backtrace:
    [<0000000004705b10>] kmemleak_alloc_recursive include/linux/kmemleak.h:43 [inline]
    [<0000000004705b10>] slab_post_alloc_hook mm/slab.h:586 [inline]
    [<0000000004705b10>] slab_alloc mm/slab.c:3320 [inline]
    [<0000000004705b10>] kmem_cache_alloc_trace+0x145/0x2c0 mm/slab.c:3549
    [<0000000036dbc592>] kmalloc include/linux/slab.h:556 [inline]
    [<0000000036dbc592>] kmalloc_array include/linux/slab.h:597 [inline]
    [<0000000036dbc592>] kcalloc include/linux/slab.h:609 [inline]
    [<0000000036dbc592>] tcf_exts_init include/net/pkt_cls.h:210 [inline]
    [<0000000036dbc592>] tcindex_alloc_perfect_hash net/sched/cls_tcindex.c:287 [inline]
    [<0000000036dbc592>] tcindex_alloc_perfect_hash+0x8f/0xf0 net/sched/cls_tcindex.c:277
    [<0000000088e6ec51>] tcindex_set_parms+0x831/0x970 net/sched/cls_tcindex.c:405
    [<000000004198237d>] tcindex_change+0xd8/0x110 net/sched/cls_tcindex.c:519
    [<00000000f90be4e9>] tc_new_tfilter+0x566/0xf50 net/sched/cls_api.c:2103
    [<00000000bdffab68>] rtnetlink_rcv_msg+0x3b2/0x4b0 net/core/rtnetlink.c:5429
    [<000000008de6f6fa>] netlink_rcv_skb+0x61/0x170 net/netlink/af_netlink.c:2477
    [<00000000637db501>] rtnetlink_rcv+0x1d/0x30 net/core/rtnetlink.c:5456
    [<00000000cb1396a7>] netlink_unicast_kernel net/netlink/af_netlink.c:1302 [inline]
    [<00000000cb1396a7>] netlink_unicast+0x223/0x310 net/netlink/af_netlink.c:1328
    [<000000003d9f7439>] netlink_sendmsg+0x2c0/0x570 net/netlink/af_netlink.c:1917
    [<0000000004922ee9>] sock_sendmsg_nosec net/socket.c:652 [inline]
    [<0000000004922ee9>] sock_sendmsg+0x54/0x70 net/socket.c:672
    [<00000000bbc6917f>] ____sys_sendmsg+0x2d0/0x300 net/socket.c:2343
    [<00000000d3ae3854>] ___sys_sendmsg+0x8a/0xd0 net/socket.c:2397
    [<0000000000c5372b>] __sys_sendmsg+0x80/0xf0 net/socket.c:2430
    [<00000000db15859a>] __do_sys_sendmsg net/socket.c:2439 [inline]
    [<00000000db15859a>] __se_sys_sendmsg net/socket.c:2437 [inline]
    [<00000000db15859a>] __x64_sys_sendmsg+0x23/0x30 net/socket.c:2437
    [<00000000a5a1c036>] do_syscall_64+0x73/0x220 arch/x86/entry/common.c:294

BUG: memory leak
unreferenced object 0xffff88811ee18800 (size 256):
  comm "syz-executor278", pid 7255, jiffies 4294941828 (age 13.710s)
  hex dump (first 32 bytes):
    00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00  ................
    00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00  ................
  backtrace:
    [<0000000004705b10>] kmemleak_alloc_recursive include/linux/kmemleak.h:43 [inline]
    [<0000000004705b10>] slab_post_alloc_hook mm/slab.h:586 [inline]
    [<0000000004705b10>] slab_alloc mm/slab.c:3320 [inline]
    [<0000000004705b10>] kmem_cache_alloc_trace+0x145/0x2c0 mm/slab.c:3549
    [<0000000036dbc592>] kmalloc include/linux/slab.h:556 [inline]
    [<0000000036dbc592>] kmalloc_array include/linux/slab.h:597 [inline]
    [<0000000036dbc592>] kcalloc include/linux/slab.h:609 [inline]
    [<0000000036dbc592>] tcf_exts_init include/net/pkt_cls.h:210 [inline]
    [<0000000036dbc592>] tcindex_alloc_perfect_hash net/sched/cls_tcindex.c:287 [inline]
    [<0000000036dbc592>] tcindex_alloc_perfect_hash+0x8f/0xf0 net/sched/cls_tcindex.c:277
    [<0000000088e6ec51>] tcindex_set_parms+0x831/0x970 net/sched/cls_tcindex.c:405
    [<000000004198237d>] tcindex_change+0xd8/0x110 net/sched/cls_tcindex.c:519
    [<00000000f90be4e9>] tc_new_tfilter+0x566/0xf50 net/sched/cls_api.c:2103
    [<00000000bdffab68>] rtnetlink_rcv_msg+0x3b2/0x4b0 net/core/rtnetlink.c:5429
    [<000000008de6f6fa>] netlink_rcv_skb+0x61/0x170 net/netlink/af_netlink.c:2477
    [<00000000637db501>] rtnetlink_rcv+0x1d/0x30 net/core/rtnetlink.c:5456
    [<00000000cb1396a7>] netlink_unicast_kernel net/netlink/af_netlink.c:1302 [inline]
    [<00000000cb1396a7>] netlink_unicast+0x223/0x310 net/netlink/af_netlink.c:1328
    [<000000003d9f7439>] netlink_sendmsg+0x2c0/0x570 net/netlink/af_netlink.c:1917
    [<0000000004922ee9>] sock_sendmsg_nosec net/socket.c:652 [inline]
    [<0000000004922ee9>] sock_sendmsg+0x54/0x70 net/socket.c:672
    [<00000000bbc6917f>] ____sys_sendmsg+0x2d0/0x300 net/socket.c:2343
    [<00000000d3ae3854>] ___sys_sendmsg+0x8a/0xd0 net/socket.c:2397
    [<0000000000c5372b>] __sys_sendmsg+0x80/0xf0 net/socket.c:2430
    [<00000000db15859a>] __do_sys_sendmsg net/socket.c:2439 [inline]
    [<00000000db15859a>] __se_sys_sendmsg net/socket.c:2437 [inline]
    [<00000000db15859a>] __x64_sys_sendmsg+0x23/0x30 net/socket.c:2437
    [<00000000a5a1c036>] do_syscall_64+0x73/0x220 arch/x86/entry/common.c:294



---
This bug is generated by a bot. It may contain errors.
See https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at syzkaller@...glegroups.com.

syzbot will keep track of this bug report. See:
https://goo.gl/tpsmEJ#status for how to communicate with syzbot.
syzbot can test patches for this bug, for details see:
https://goo.gl/tpsmEJ#testing-patches