netdev - Re: [PATCH net v3] dpaa_eth: support all modes with rate adapting PHYs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20200205.135303.1962769321789048036.davem@davemloft.net>
Date:   Wed, 05 Feb 2020 13:53:03 +0100 (CET)
From:   David Miller <davem@...emloft.net>
To:     madalin.bucur@....nxp.com
Cc:     andrew@...n.ch, f.fainelli@...il.com, hkallweit1@...il.com,
        netdev@...r.kernel.org, ykaukab@...e.de
Subject: Re: [PATCH net v3] dpaa_eth: support all modes with rate adapting
 PHYs

From: Madalin Bucur <madalin.bucur@....nxp.com>
Date: Tue,  4 Feb 2020 12:08:58 +0200

> Stop removing modes that are not supported on the system interface
> when the connected PHY is capable of rate adaptation. This addresses
> an issue with the LS1046ARDB board 10G interface no longer working
> with an 1G link partner after autonegotiation support was added
> for the Aquantia PHY on board in
> 
> commit 09c4c57f7bc4 ("net: phy: aquantia: add support for auto-negotiation configuration")
> 
> Before this commit the values advertised by the PHY were not
> influenced by the dpaa_eth driver removal of system-side unsupported
> modes as the aqr_config_aneg() was basically a no-op. After this
> commit, the modes removed by the dpaa_eth driver were no longer
> advertised thus autonegotiation with 1G link partners failed.
> 
> Reported-by: Mian Yousaf Kaukab <ykaukab@...e.de>
> Signed-off-by: Madalin Bucur <madalin.bucur@....nxp.com>
> ---
> 
> change in v3: no longer add an API for checking the capability,
>   rely on PHY vendor to determine if more modes may be available
>   through rate adaptation so stop removing them

There was quite a discussion about the approach that should be used here
in the short term.

Therefore I'd like some reviews and ACKs from interested parties such as
Andrew, Florian, and Heiner.

Thanks.