netdev - Re: [PATCH net] r8169: fix performance regression related to PCIe max read request size

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 06 Feb 2020 14:20:51 +0100 (CET)
From:   David Miller <davem@...emloft.net>
To:     hkallweit1@...il.com
Cc:     nic_swsd@...ltek.com, netdev@...r.kernel.org
Subject: Re: [PATCH net] r8169: fix performance regression related to PCIe
 max read request size

From: Heiner Kallweit <hkallweit1@...il.com>
Date: Wed, 5 Feb 2020 21:22:46 +0100

> It turned out that on low performance systems the original change can
> cause lower tx performance. On a N3450-based mini-PC tx performance
> in iperf3 was reduced from 950Mbps to ~900Mbps. Therefore effectively
> revert the original change, just use pcie_set_readrq() now instead of
> changing the PCIe capability register directly.
> 
> Fixes: 2df49d365498 ("r8169: remove fiddling with the PCIe max read request size")
> Signed-off-by: Heiner Kallweit <hkallweit1@...il.com>

Applied and queued up for v5.5 -stable, thanks.