netdev - Re: [PATCH net] net: systemport: Avoid RBUF stuck in Wake-on-LAN mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200206.142954.1457791883934476387.davem@davemloft.net>
Date:   Thu, 06 Feb 2020 14:29:54 +0100 (CET)
From:   David Miller <davem@...emloft.net>
To:     f.fainelli@...il.com
Cc:     netdev@...r.kernel.org, bcm-kernel-feedback-list@...adcom.com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH net] net: systemport: Avoid RBUF stuck in Wake-on-LAN
 mode

From: Florian Fainelli <f.fainelli@...il.com>
Date: Wed,  5 Feb 2020 12:32:04 -0800

> After a number of suspend and resume cycles, it is possible for the RBUF
> to be stuck in Wake-on-LAN mode, despite the MPD enable bit being
> cleared which instructed the RBUF to exit that mode.

Must be some weird state latching or something like that...

> Avoid creating that problematic condition by clearing the RX_EN and
> TX_EN bits in the UniMAC prior to disable the Magic Packet Detector
> logic which is guaranteed to make the RBUF exit Wake-on-LAN mode.
> 
> Fixes: 83e82f4c706b ("net: systemport: add Wake-on-LAN support")
> Signed-off-by: Florian Fainelli <f.fainelli@...il.com>

Applied and queued up for -stable, thanks.