netdev - Re: [PATCH v2] net: stmmac: fix a possible endless loop

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200206.155025.1955610977652855941.davem@davemloft.net>
Date:   Thu, 06 Feb 2020 15:50:25 +0100 (CET)
From:   David Miller <davem@...emloft.net>
To:     zhengdejin5@...il.com
Cc:     vkoul@...nel.org, peppe.cavallaro@...com, joabreu@...opsys.com,
        mcoquelin.stm32@...il.com, niklas.cassel@...aro.org,
        netdev@...r.kernel.org, linux-stm32@...md-mailman.stormreply.com,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] net: stmmac: fix a possible endless loop

From: Dejin Zheng <zhengdejin5@...il.com>
Date: Thu,  6 Feb 2020 22:18:11 +0800

> It forgot to reduce the value of the variable retry in a while loop
> in the ethqos_configure() function. It may cause an endless loop and
> without timeout.
> 
> Fixes: a7c30e62d4b8 ("net: stmmac: Add driver for Qualcomm ethqos")
> 
> Signed-off-by: Dejin Zheng <zhengdejin5@...il.com>
> Acked-by: Vinod Koul <vkoul@...nel.org>
> ---
> 
> Vinod Koul and David Miller, Thanks for your comments!
> 
> V2:
> add an appropriate Fixes tag.

Please do not put an empty line between Fixes and other tags.

I have no idea why people often do this.

Anyways, Fixes and other tags are all tags and thus belong together as
an uninterrupted group of text.

Thank you.