netdev - Re: [PATCH bpf-next v4] virtio_net: add XDP meta data support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0c5eaba2-dd5a-fc3f-0e8f-154f7ad52881@redhat.com>
Date:   Thu, 6 Feb 2020 11:20:24 +0800
From:   Jason Wang <jasowang@...hat.com>
To:     Yuya Kusakabe <yuya.kusakabe@...il.com>
Cc:     ast@...nel.org, daniel@...earbox.net, davem@...emloft.net,
        hawk@...nel.org, john.fastabend@...il.com, kafai@...com,
        mst@...hat.com, songliubraving@...com, yhs@...com, kuba@...nel.org,
        andriin@...com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, bpf@...r.kernel.org
Subject: Re: [PATCH bpf-next v4] virtio_net: add XDP meta data support


On 2020/2/5 下午5:18, Yuya Kusakabe wrote:
>>>            case XDP_TX:
>>>                stats->xdp_tx++;
>>> +            xdp.data_meta = xdp.data;
>> Any reason for doing this?
> XDP_TX can not support metadata for now, because if metasize > 0, __virtnet_xdp_xmit_one() returns EOPNOTSUPP.
>
> static int __virtnet_xdp_xmit_one(struct virtnet_info *vi,
> 				   struct send_queue *sq,
> 				   struct xdp_frame *xdpf)
> {
> 	struct virtio_net_hdr_mrg_rxbuf *hdr;
> 	int err;
>
> 	/* virtqueue want to use data area in-front of packet */
> 	if (unlikely(xdpf->metasize > 0))
> 		return -EOPNOTSUPP;
>
>

I see.

Then I think it's better to fix __virtnet_xdp_xmit_one() instead.

Thanks