netdev - Re: [PATCH net] net: ethernet: ave: Add capability of rgmii-id mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20200207.111648.1915539223489764931.davem@davemloft.net>
Date:   Fri, 07 Feb 2020 11:16:48 +0100 (CET)
From:   David Miller <davem@...emloft.net>
To:     hayashi.kunihiko@...ionext.com
Cc:     netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        masami.hiramatsu@...aro.org, jaswinder.singh@...aro.org
Subject: Re: [PATCH net] net: ethernet: ave: Add capability of rgmii-id mode

From: Kunihiko Hayashi <hayashi.kunihiko@...ionext.com>
Date: Thu,  6 Feb 2020 10:59:36 +0900

> This allows you to specify the type of rgmii-id that will enable phy
> internal delay in ethernet phy-mode.
> 
> Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@...ionext.com>

I do not understand this change at all.

At a minimum you must explain things more clearly and completely in your
commit message.

Are you just adding all of the RGMII cases to the code that only currently
mentions PHY_INTERFACE_MODE_RGMII?  If so, why did you only do this for
some but not all of the get_pinmode() methods in this driver?

Thank you.