netdev - Re: [PATCH net v4 0/5] taprio: Some fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200207.113144.779256801446560370.davem@davemloft.net>
Date:   Fri, 07 Feb 2020 11:31:44 +0100 (CET)
From:   David Miller <davem@...emloft.net>
To:     vinicius.gomes@...el.com
Cc:     netdev@...r.kernel.org, jhs@...atatu.com, xiyou.wangcong@...il.com,
        jiri@...nulli.us, vladimir.oltean@....com, po.liu@....com
Subject: Re: [PATCH net v4 0/5] taprio: Some fixes

From: Vinicius Costa Gomes <vinicius.gomes@...el.com>
Date: Thu,  6 Feb 2020 13:46:05 -0800

 ...
> One bit that might need some attention is the fix for not dropping all
> packets when taprio and ETF offloading are used, patch 5/5. The
> behavior when the fix is applied is that packets that have a 'txtime'
> that would fall outside of their transmission window are now dropped
> by taprio. The question that might be raised is: should taprio be
> responsible for dropping these packets, or should it be handled lower
> in the stack?
> 
> My opinion is: taprio has all the information, and it's able to give
> feeback to the user. Lower in the stack, those packets might go into
> the void, and the only feedback could be a hard to find counter
> increasing.
> 
> Patch 1/5: Reported by Po Liu, is more of a improvement of usability for
> drivers implementing offloading features, now they can rely on the
> value of dev->num_tc, instead of going through some hops to get this
> value.
> 
> Patch 2/5: Use 'q->flags' as the source of truth for the offloading
> flags. Tries to solidify the current behavior, while avoiding going
> into invalid states, one of which was causing a "rcu stall" (more
> information in the commit message).
> 
> Patch 3/5: Adds the missing netlink attribute validation for
> TCA_TAPRIO_ATTR_FLAGS.
> 
> Patch 4/5: Replaces the usage of netdev_set_num_tc() with
> netdev_reset_tc() in taprio_destroy(), taprio_destroy() is called when
> applying a configuration fails, making sure that the device traffic
> class configuration goes back to the default state.
 ....

Series applied, thank you.