netdev - Re: [PATCH net] drop_monitor: Do not cancel uninitialized work item

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20200207.184922.684717862938638775.davem@davemloft.net>
Date:   Fri, 07 Feb 2020 18:49:22 +0100 (CET)
From:   David Miller <davem@...emloft.net>
To:     idosch@...sch.org
Cc:     netdev@...r.kernel.org, kuba@...nel.org, nhorman@...driver.com,
        jiri@...lanox.com, mlxsw@...lanox.com, idosch@...lanox.com
Subject: Re: [PATCH net] drop_monitor: Do not cancel uninitialized work item

From: Ido Schimmel <idosch@...sch.org>
Date: Fri,  7 Feb 2020 19:29:28 +0200

> From: Ido Schimmel <idosch@...lanox.com>
> 
> Drop monitor uses a work item that takes care of constructing and
> sending netlink notifications to user space. In case drop monitor never
> started to monitor, then the work item is uninitialized and not
> associated with a function.
> 
> Therefore, a stop command from user space results in canceling an
> uninitialized work item which leads to the following warning [1].
> 
> Fix this by not processing a stop command if drop monitor is not
> currently monitoring.
...
> Fixes: 8e94c3bc922e ("drop_monitor: Allow user to start monitoring hardware drops")
> Signed-off-by: Ido Schimmel <idosch@...lanox.com>
> Reviewed-by: Jiri Pirko <jiri@...lanox.com>

Applied and queued up for v5.4+ -stable, thanks.