netdev - Re: [PATCH net-next] qmi_wwan: unconditionally reject 2 ep interfaces

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20200210.140348.1963500382587025261.davem@davemloft.net>
Date:   Mon, 10 Feb 2020 14:03:48 +0100 (CET)
From:   David Miller <davem@...emloft.net>
To:     bjorn@...k.no
Cc:     netdev@...r.kernel.org, linux-usb@...r.kernel.org,
        kristian.evensen@...il.com, aleksander@...ksander.es
Subject: Re: [PATCH net-next] qmi_wwan: unconditionally reject 2 ep
 interfaces

From: Bjørn Mork <bjorn@...k.no>
Date: Sat,  8 Feb 2020 16:55:04 +0100

> We have been using the fact that the QMI and DIAG functions
> usually are the only ones with class/subclass/protocol being
> ff/ff/ff on Quectel modems. This has allowed us to match the
> QMI function without knowing the exact interface number,
> which can vary depending on firmware configuration.
> 
> The ability to silently reject the DIAG function, which is
> usually handled by the option driver, is important for this
> method to work.  This is done based on the knowledge that it
> has exactly 2 bulk endpoints.  QMI function control interfaces
> will have either 3 or 1 endpoint. This rule is universal so
> the quirk condition can be removed.
> 
> The fixed layouts known from the Gobi1k and Gobi2k modems
> have been gradually replaced by more dynamic layouts, and
> many vendors now use configurable layouts without changing
> device IDs.  Renaming the class/subclass/protocol matching
> macro makes it more obvious that this is now not Quectel
> specific anymore.
> 
> Cc: Kristian Evensen <kristian.evensen@...il.com>
> Cc: Aleksander Morgado <aleksander@...ksander.es>
> Signed-off-by: Bjørn Mork <bjorn@...k.no>

Applied.