netdev - Re: [PATCH ftgmac100:] Return link speed and duplex settings for the NCSI channel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <428fc9e1-d421-c6d6-b134-864ce3112b61@intel.com>
Date:   Mon, 10 Feb 2020 11:15:30 -0800
From:   Johnathan Mantey <johnathanx.mantey@...el.com>
To:     David Miller <davem@...emloft.net>
Cc:     netdev@...r.kernel.org, sam@...dozajonas.com
Subject: Re: [PATCH ftgmac100:] Return link speed and duplex settings for the
 NCSI channel



On 1/29/20 2:44 AM, David Miller wrote:
> From: Johnathan Mantey <johnathanx.mantey@...el.com>
> Date: Mon, 27 Jan 2020 11:17:50 -0800
> 
>> @@ -1218,10 +1218,30 @@ static int ftgmac100_set_pauseparam(struct
>> net_device *netdev,
> 
> Please fix your email client so that the patch is not mangled like this.
> 
>>  	return 0;
>>  }
>>
>> +int ftgmac100_ethtool_get_link_ksettings(struct net_device *netdev,
>> +					 struct ethtool_link_ksettings *cmd)
>> +{
>> +	struct phy_device *phydev = netdev->phydev;
>> +	struct ftgmac100 *priv = netdev_priv(netdev);
>> +	int retval = 0;
>> +
>> +	if (phydev) {
>> +		phy_ethtool_ksettings_get(phydev, cmd);
> 
> This should be retval = phy_ethtool_ksettings_get() otherwise error indications
> will not propagate.
> 

This can't be done. The phy_ethtool_ksettings_get() is a void returning
function. Trying to capture retval results in a compile error.

-- 
Johnathan Mantey
Senior Software Engineer
*azad technology partners*
Contributing to Technology Innovation since 1992
Phone: (503) 712-6764
Email: johnathanx.mantey@...el.com <mailto:johnathanx.mantey@...el.com>