netdev - Re: [PATCH v2 net 1/5] icmp: introduce helper for NAT'd source address in network device context

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHmME9pMaJ_OTCEVWkW=RmPSBxq6xneSiDUmZ=zGnkM1Cj5S7A@mail.gmail.com>
Date:   Tue, 11 Feb 2020 13:25:58 +0100
From:   "Jason A. Donenfeld" <Jason@...c4.com>
To:     Florian Westphal <fw@...len.de>
Cc:     Netdev <netdev@...r.kernel.org>, David Miller <davem@...emloft.net>
Subject: Re: [PATCH v2 net 1/5] icmp: introduce helper for NAT'd source
 address in network device context

On Mon, Feb 10, 2020 at 10:33 PM Florian Westphal <fw@...len.de> wrote:
> I also suggest to check "ct->status & IPS_NAT_MASK", nat is only done if
> those bits are set.

We can optimize even further, because we only care about the IPS_SRC_NAT case.