netdev - Re: [PATCH net-next] sfc: remove unused variable 'efx_default_channel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e246665f-fe9b-ec62-a621-0ea0dff06771@solarflare.com>
Date:   Tue, 11 Feb 2020 14:56:50 +0000
From:   Martin Habets <mhabets@...arflare.com>
To:     YueHaibing <yuehaibing@...wei.com>,
        <linux-net-drivers@...arflare.com>, <ecree@...arflare.com>,
        <davem@...emloft.net>
CC:     <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net-next] sfc: remove unused variable
 'efx_default_channel_type'

On 11/02/2020 14:16, YueHaibing wrote:
> drivers/net/ethernet/sfc/efx.c:116:38: warning:
>  efx_default_channel_type defined but not used [-Wunused-const-variable=]

This is a good fix, but net-next is closed at the moment. Please resubmit it when it reopens.

> commit 83975485077d ("sfc: move channel alloc/removal code")
> left behind this, remove it.

Please add this info with a "Fixes:" tag.

Thanks,
Martin

> 
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>
> ---
>  drivers/net/ethernet/sfc/efx.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/sfc/efx.c b/drivers/net/ethernet/sfc/efx.c
> index 4481f21a1f43..256807c28ff7 100644
> --- a/drivers/net/ethernet/sfc/efx.c
> +++ b/drivers/net/ethernet/sfc/efx.c
> @@ -113,7 +113,6 @@ MODULE_PARM_DESC(debug, "Bitmapped debugging message enable value");
>   *
>   *************************************************************************/
>  
> -static const struct efx_channel_type efx_default_channel_type;
>  static void efx_remove_port(struct efx_nic *efx);
>  static int efx_xdp_setup_prog(struct efx_nic *efx, struct bpf_prog *prog);
>  static int efx_xdp(struct net_device *dev, struct netdev_bpf *xdp);
>