lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 11 Feb 2020 16:00:25 +0100 From: "Jason A. Donenfeld" <Jason@...c4.com> To: netdev@...r.kernel.org, davem@...emloft.net Cc: "Jason A. Donenfeld" <Jason@...c4.com>, stefanr@...6.in-berlin.de Subject: [PATCH v3 net 6/9] firewire: remove skb_share_check from xmit path This is an impossible condition to reach; an skb in ndo_start_xmit won't be shared by definition. Signed-off-by: Jason A. Donenfeld <Jason@...c4.com> Cc: stefanr@...6.in-berlin.de Link: https://lore.kernel.org/netdev/CAHmME9pk8HEFRq_mBeatNbwXTx7UEfiQ_HG_+Lyz7E+80GmbSA@mail.gmail.com/ --- drivers/firewire/net.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/firewire/net.c b/drivers/firewire/net.c index 715e491dfbc3..c48eae922566 100644 --- a/drivers/firewire/net.c +++ b/drivers/firewire/net.c @@ -1259,10 +1259,6 @@ static netdev_tx_t fwnet_tx(struct sk_buff *skb, struct net_device *net) if (ptask == NULL) goto fail; - skb = skb_share_check(skb, GFP_ATOMIC); - if (!skb) - goto fail; - /* * Make a copy of the driver-specific header. * We might need to rebuild the header on tx failure. -- 2.25.0
Powered by blists - more mailing lists