netdev - Re: [v2] ptp_qoriq: add initialization message

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200212.095244.2041379255661139484.davem@davemloft.net>
Date:   Wed, 12 Feb 2020 09:52:44 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     yangbo.lu@....com
Cc:     netdev@...r.kernel.org, richardcochran@...il.com
Subject: Re: [v2] ptp_qoriq: add initialization message

From: Yangbo Lu <yangbo.lu@....com>
Date: Wed, 12 Feb 2020 18:19:16 +0800

> Current ptp_qoriq driver prints only warning or error messages.
> It may be loaded successfully without any messages.
> Although this is fine, it would be convenient to have an oneline
> initialization log showing success and PTP clock index.
> The goods are,
> - The ptp_qoriq driver users may know whether this driver is loaded
>   successfully, or not, or not loaded from the booting log.
> - The ptp_qoriq driver users don't have to install an ethtool to
>   check the PTP clock index for using. Or don't have to check which
>   /sys/class/ptp/ptpX is PTP QorIQ clock.
> 
> Signed-off-by: Yangbo Lu <yangbo.lu@....com>
> ---
> Changes for v2:
> 	- Added more in commit message.

I explained yesterday why your change is inappropriate and why I won't
be applying your patch.

It is not appropriate to send the same patch again with a different
commit message.

What might be appropriate is replying to my email and explaining your
side of the argument and why you think it is appropriate.

You must engage with other developers and discuss your change here on
the list if you want us to consider it still.

Thank you.