netdev - Re: [PATCH net 1/2] net/sched: matchall: add missing validation of TCA_MATCHALL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 12 Feb 2020 08:28:21 +0100
From:   Jiri Pirko <jiri@...nulli.us>
To:     Davide Caratti <dcaratti@...hat.com>
Cc:     Amir Vadai <amir@...ai.me>, Yotam Gigi <yotamg@...lanox.com>,
        Jiri Pirko <jiri@...lanox.com>,
        "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org
Subject: Re: [PATCH net 1/2] net/sched: matchall: add missing validation of
 TCA_MATCHALL_FLAGS

Tue, Feb 11, 2020 at 07:33:39PM CET, dcaratti@...hat.com wrote:
>unlike other classifiers that can be offloaded (i.e. users can set flags
>like 'skip_hw' and 'skip_sw'), 'cls_matchall' doesn't validate the size
>of netlink attribute 'TCA_MATCHALL_FLAGS' provided by user: add a proper
>entry to mall_policy.
>
>Fixes: b87f7936a932 ("net/sched: Add match-all classifier hw offloading.")
>Signed-off-by: Davide Caratti <dcaratti@...hat.com>

I was actually about to send these :)
Thanks

Acked-by: Jiri Pirko <jiri@...lanox.com>