netdev - Re: [PATCH] treewide: Replace zero-length arrays with flexible-array member

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 12 Feb 2020 09:36:10 +0100
From:   Kars de Jong <karsdejong@...e.nl>
To:     Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:     "Gustavo A. R. Silva" <gustavo@...eddedor.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Kees Cook <keescook@...omium.org>,
        "David S. Miller" <davem@...emloft.net>,
        Greg KH <gregkh@...uxfoundation.org>,
        Linux Crypto Mailing List <linux-crypto@...r.kernel.org>,
        netdev <netdev@...r.kernel.org>,
        USB list <linux-usb@...r.kernel.org>,
        linux-m68k <linux-m68k@...ts.linux-m68k.org>
Subject: Re: [PATCH] treewide: Replace zero-length arrays with flexible-array member

Op wo 12 feb. 2020 om 09:00 schreef Geert Uytterhoeven <geert@...ux-m68k.org>:
>
> Hi Gustavo,
>
> On Tue, Feb 11, 2020 at 10:49 PM Gustavo A. R. Silva
> <gustavo@...eddedor.com> wrote:
> > --- a/arch/m68k/tools/amiga/dmesg.c
> > +++ b/arch/m68k/tools/amiga/dmesg.c
> > @@ -34,7 +34,7 @@ struct savekmsg {
> >      u_long magic2;     /* SAVEKMSG_MAGIC2 */
> >      u_long magicptr;   /* address of magic1 */
> >      u_long size;
> > -    char data[0];
> > +       char data[];
> >  };
>
> JFTR, this file is not really part of the kernel, but supposed to be compiled
> by an AmigaOS compiler, which may predate the introduction of support
> for flexible array members.

FYI, there's a reasonably modern toolchain for AmigaOS which can
compile this just fine (https://github.com/bebbo/amiga-gcc).

> Well, even if you keep it included, I guess the rare users can manage ;-)
> My binary dates back to 1996, and I have no plans to recompile it.

I did, just to check whether it still worked.

Kind regards,

Kars.