netdev - RE: [PATCH] ptp_qoriq: add initialization message

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AM7PR04MB68852520F30921405A717B6CF81B0@AM7PR04MB6885.eurprd04.prod.outlook.com>
Date:   Wed, 12 Feb 2020 10:24:27 +0000
From:   "Y.b. Lu" <yangbo.lu@....com>
To:     David Miller <davem@...emloft.net>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "richardcochran@...il.com" <richardcochran@...il.com>
Subject: RE: [PATCH] ptp_qoriq: add initialization message

> -----Original Message-----
> From: netdev-owner@...r.kernel.org <netdev-owner@...r.kernel.org> On
> Behalf Of David Miller
> Sent: Wednesday, February 12, 2020 9:07 AM
> To: Y.b. Lu <yangbo.lu@....com>
> Cc: netdev@...r.kernel.org; richardcochran@...il.com
> Subject: Re: [PATCH] ptp_qoriq: add initialization message
> 
> From: Yangbo Lu <yangbo.lu@....com>
> Date: Tue, 11 Feb 2020 12:50:53 +0800
> 
> > It is necessary to print the initialization result.
> 
> No, it is not.

Sorry, I should have added my reasons into commit message.
I sent out v2. Do you think if it makes sense?

" Current ptp_qoriq driver prints only warning or error messages.
It may be loaded successfully without any messages.
Although this is fine, it would be convenient to have an oneline
initialization log showing success and PTP clock index.
The goods are,
- The ptp_qoriq driver users may know whether this driver is loaded
  successfully, or not, or not loaded from the booting log.
- The ptp_qoriq driver users don't have to install an ethtool to
  check the PTP clock index for using. Or don't have to check which
  /sys/class/ptp/ptpX is PTP QorIQ clock."

Thanks.