netdev - Re: [PATCH net] net/smc: fix leak of kernel memory to user space

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200211.170529.1525657879668637958.davem@davemloft.net>
Date:   Tue, 11 Feb 2020 17:05:29 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     edumazet@...gle.com
Cc:     netdev@...r.kernel.org, eric.dumazet@...il.com,
        ubraun@...ux.vnet.ibm.com
Subject: Re: [PATCH net] net/smc: fix leak of kernel memory to user space

From: Eric Dumazet <edumazet@...gle.com>
Date: Mon, 10 Feb 2020 11:36:13 -0800

> As nlmsg_put() does not clear the memory that is reserved,
> it this the caller responsability to make sure all of this
> memory will be written, in order to not reveal prior content.
> 
> While we are at it, we can provide the socket cookie even
> if clsock is not set.
> 
> syzbot reported :
 ...
> Fixes: f16a7dd5cf27 ("smc: netlink interface for SMC sockets")
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Cc: Ursula Braun <ubraun@...ux.vnet.ibm.com>

Applied and queued up for -stable, thanks.