netdev - Re: [PATCHv2 iproute2-next 1/7] iproute_lwtunnel: add options support for geneve metadata

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200213082635.0fde6ab8@hermes.lan>
Date:   Thu, 13 Feb 2020 08:26:35 -0800
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     Xin Long <lucien.xin@...il.com>
Cc:     network dev <netdev@...r.kernel.org>,
        Simon Horman <simon.horman@...ronome.com>
Subject: Re: [PATCHv2 iproute2-next 1/7] iproute_lwtunnel: add options
 support for geneve metadata

On Thu, 13 Feb 2020 19:56:59 +0800
Xin Long <lucien.xin@...il.com> wrote:

> +	while (rem) {
> +		parse_rtattr(tb, LWTUNNEL_IP_OPT_GENEVE_MAX, i, rem);
> +		class = rta_getattr_be16(tb[LWTUNNEL_IP_OPT_GENEVE_CLASS]);
> +		type = rta_getattr_u8(tb[LWTUNNEL_IP_OPT_GENEVE_TYPE]);
> +		data_len = RTA_PAYLOAD(tb[LWTUNNEL_IP_OPT_GENEVE_DATA]);
> +		hexstring_n2a(RTA_DATA(tb[LWTUNNEL_IP_OPT_GENEVE_DATA]),
> +			      data_len, data, sizeof(data));
> +		offset += data_len + 20;
> +		rem -= data_len + 20;
> +		i = RTA_DATA(attr) + offset;
> +		slen += sprintf(opt + slen, "%04x:%02x:%s", class, type, data);
> +		if (rem)
> +		

Please implement proper JSON array for these. Not just bunch of strings.