netdev - Re: [PATCH] vsock.7: add VMADDR_CID

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200213094418.5b5jkkcsudbi4z4l@steredhat>
Date:   Thu, 13 Feb 2020 10:44:18 +0100
From:   Stefano Garzarella <sgarzare@...hat.com>
To:     Stefan Hajnoczi <stefanha@...hat.com>
Cc:     mtk.manpages@...il.com, netdev@...r.kernel.org,
        linux-man@...r.kernel.org, Dexuan Cui <decui@...rosoft.com>,
        Jorgen Hansen <jhansen@...are.com>
Subject: Re: [PATCH] vsock.7: add VMADDR_CID_LOCAL description

On Thu, Feb 13, 2020 at 09:17:48AM +0000, Stefan Hajnoczi wrote:
> On Tue, Feb 11, 2020 at 11:25:32AM +0100, Stefano Garzarella wrote:
> 
> Do you want to mention that loopback works in the guest and on the host
> since Linux vX.Y and before that it only worked inside the guest?

I didn't mention it, because it was only supported by some transports
(vmci, virtio), but it makes sense to say it, I'll add.

> 
> > @@ -164,6 +164,16 @@ Consider using
> >  .B VMADDR_CID_ANY
> >  when binding instead of getting the local CID with
> >  .BR IOCTL_VM_SOCKETS_GET_LOCAL_CID .
> > +.SS Local communication
> > +The
> > +.B VMADDR_CID_LOCAL
> > +(1) can be used to address itself. In this case all packets are redirected
> > +to the same host that generated them. Useful for testing and debugging.
> 
> This can be rephrased more naturally:
> 
> .B VMADDR_CID_LOCAL
> (1) directs packets to the same host that generated them. This is useful
> for testing applications on a single host and for debugging.

Sure, it is better, I'll fix.

Thanks,
Stefano