netdev - Re: [PATCH ipsec] xfrm: fix uctx len check in verify_sec_ctx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 13 Feb 2020 10:55:38 +0100
From:   Steffen Klassert <steffen.klassert@...unet.com>
To:     Xin Long <lucien.xin@...il.com>
CC:     <netdev@...r.kernel.org>, Herbert Xu <herbert@...dor.apana.org.au>,
        "David S. Miller" <davem@...emloft.net>,
        Trent Jaeger <tjaeger@....psu.edu>,
        Jamal Hadi Salim <hadi@...erus.ca>,
        Sabrina Dubroca <sd@...asysnail.net>
Subject: Re: [PATCH ipsec] xfrm: fix uctx len check in verify_sec_ctx_len

On Sun, Feb 09, 2020 at 09:15:29PM +0800, Xin Long wrote:
> It's not sufficient to do 'uctx->len != (sizeof(struct xfrm_user_sec_ctx) +
> uctx->ctx_len)' check only, as uctx->len may be greater than nla_len(rt),
> in which case it will cause slab-out-of-bounds when accessing uctx->ctx_str
> later.
> 
> This patch is to fix it by return -EINVAL when uctx->len > nla_len(rt).
> 
> Fixes: df71837d5024 ("[LSM-IPSec]: Security association restriction.")
> Signed-off-by: Xin Long <lucien.xin@...il.com>

Applied, thanks!