lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 14 Feb 2020 08:20:28 -0800 From: Jakub Kicinski <kuba@...nel.org> To: Cris Forno <cforno12@...ux.vnet.ibm.com> Cc: netdev@...r.kernel.org, mst@...hat.com, jasowang@...hat.com, haiyangz@...rosoft.com, sthemmin@...rosoft.com, sashal@...nel.org, tlfalcon@...ux.ibm.com, davem@...emloft.net, mkubecek@...e.cz, willemdebruijn.kernel@...il.com Subject: Re: [PATCH, net-next, v4, 1/2] ethtool: Factored out similar ethtool link settings for virtual devices to core On Thu, 13 Feb 2020 14:14:09 -0600 Cris Forno wrote: > diff --git a/include/linux/ethtool.h b/include/linux/ethtool.h > index 95991e43..149f982 100644 > --- a/include/linux/ethtool.h > +++ b/include/linux/ethtool.h > @@ -394,6 +394,8 @@ struct ethtool_ops { > struct ethtool_coalesce *); > int (*set_per_queue_coalesce)(struct net_device *, u32, > struct ethtool_coalesce *); > + bool (*virtdev_validate_link_ksettings)(const struct > + ethtool_link_ksettings *); Could this callback be passed to ethtool_virtdev_set_link_ksettings() as an argument instead of being in the global structure? Callers need to pass speed and duplex pointers anyway. > int (*get_link_ksettings)(struct net_device *, > struct ethtool_link_ksettings *); > int (*set_link_ksettings)(struct net_device *,
Powered by blists - more mailing lists