netdev - Re: About r8169 regression 5.4

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 14 Feb 2020 21:14:50 +0100
From:   Heiner Kallweit <hkallweit1@...il.com>
To:     Vincas Dargis <vindrg@...il.com>
Cc:     netdev@...r.kernel.org
Subject: Re: About r8169 regression 5.4

On 14.02.2020 18:21, Vincas Dargis wrote:
> Hi,
> 
> I've found similar issue I have myself since 5.4 on mailing list archive [0], for this device:
> 
Thanks for reporting. As you refer to [0], do you use jumbo packets?


> 05:00.1 Ethernet controller: Realtek Semiconductor Co., Ltd. RTL8111/8168/8411 PCI Express Gigabit Ethernet Controller (rev 12)
>         Subsystem: ASUSTeK Computer Inc. RTL8111/8168/8411 PCI Express Gigabit Ethernet Controller
> 
> 
> It works fine as long as I select 5.3 in Grub (it seems no longer maintained in Debian Sid though...)
> 
> I see number of commits in net/etherenet/realtek tree, not sure if fix is there, or do we need another fix for this particular device? I've keep testing latest Debian kernel updates (latest is 5.4.19-1), and no good news yet.
> 
Best of course would be a bisect between 5.3 and 5.4. Can you do this?
I have no test hardware with this chip version (RTL8411B).

You could also try to revert a7a92cf81589 ("r8169: sync PCIe PHY init with vendor driver 8.047.01")
and check whether this fixes your issue.
In addition you could test latest 5.5-rc, or linux-next.

> There's Debian bug report [1] which might contain more information.
> 
> Some extra info:
> 
> $ sudo ethtool -i enp5s0f1
> driver: r8169
> version:
> firmware-version: rtl8411-2_0.0.1 07/08/13
> expansion-rom-version:
> bus-info: 0000:05:00.1
> supports-statistics: yes
> supports-test: no
> supports-eeprom-access: no
> supports-register-dump: yes
> supports-priv-flags: no
> 
> 
> $ sudo mii-tool -v enp5s0f1
> enp5s0f1: negotiated 1000baseT-FD flow-control, link ok
>   product info: vendor 00:07:32, model 0 rev 0
>   basic mode:   autonegotiation enabled
>   basic status: autonegotiation complete, link ok
>   capabilities: 1000baseT-FD 100baseTx-FD 100baseTx-HD 10baseT-FD 10baseT-HD
>   advertising:  1000baseT-FD 100baseTx-FD 100baseTx-HD 10baseT-FD 10baseT-HD flow-control
>   link partner: 1000baseT-FD 100baseTx-FD 100baseTx-HD 10baseT-FD 10baseT-HD flow-control
> 
> 
> [0] https://lkml.org/lkml/2019/11/30/119
> [1] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=947685

Heiner