netdev - Re: [PATCH v3 net 4/4] wireguard: socket: remove extra call to synchronize

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d29e7d7e-5e60-9790-4851-eaf7bc14a58c@gmail.com>
Date:   Fri, 14 Feb 2020 15:21:59 -0800
From:   Eric Dumazet <eric.dumazet@...il.com>
To:     "Jason A. Donenfeld" <Jason@...c4.com>, davem@...emloft.net,
        netdev@...r.kernel.org
Cc:     Eric Dumazet <eric.dumazet@...il.com>
Subject: Re: [PATCH v3 net 4/4] wireguard: socket: remove extra call to
 synchronize_net



On 2/14/20 2:57 PM, Jason A. Donenfeld wrote:
> synchronize_net() is a wrapper around synchronize_rcu(), so there's no
> point in having synchronize_net and synchronize_rcu back to back,
> despite the documentation comment suggesting maybe it's somewhat useful,
> "Wait for packets currently being received to be done." This commit
> removes the extra call.
> 
> Signed-off-by: Jason A. Donenfeld <Jason@...c4.com>
> Suggested-by: Eric Dumazet <eric.dumazet@...il.com>

Reviewed-by: Eric Dumazet <edumazet@...gle.com>

Thanks !