netdev - Re: [PATCH net-next 04/10] net: phylink: remove pause mode ethtool setting for fixed links

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200215185701.GU31084@lunn.ch>
Date:   Sat, 15 Feb 2020 19:57:01 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Russell King <rmk+kernel@...linux.org.uk>
Cc:     Florian Fainelli <f.fainelli@...il.com>,
        Heiner Kallweit <hkallweit1@...il.com>,
        "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org
Subject: Re: [PATCH net-next 04/10] net: phylink: remove pause mode ethtool
 setting for fixed links

On Sat, Feb 15, 2020 at 03:49:37PM +0000, Russell King wrote:
> Remove the ability for ethtool -A to change the pause settings for
> fixed links; if this is really required, we can reinstate it later.
> 
> Andrew Lunn agrees: "So I think it is safe to not implement ethtool
> -A, at least until somebody has a real use case for it."
> 
> Lets avoid making things too complex for use cases that aren't being
> used.
> 
> Signed-off-by: Russell King <rmk+kernel@...linux.org.uk>

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew