netdev - Re: [PATCH net-next 09/10] net: phylink: improve initial mac configuration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200215190630.GY31084@lunn.ch>
Date:   Sat, 15 Feb 2020 20:06:30 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Russell King <rmk+kernel@...linux.org.uk>
Cc:     Florian Fainelli <f.fainelli@...il.com>,
        Heiner Kallweit <hkallweit1@...il.com>,
        "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org
Subject: Re: [PATCH net-next 09/10] net: phylink: improve initial mac
 configuration

On Sat, Feb 15, 2020 at 03:50:03PM +0000, Russell King wrote:
> Improve the initial MAC configuration so we get a configuration which
> more represents the final operating mode, in particular with respect
> to the flow control settings.
> 
> We do this by:
> 1) more fully initialising our phy state, so we can use this as the
>    initial state for PHY based connections.
> 2) reading the fixed link state.
> 3) ensuring that in-band mode has sane pause settings for SGMII vs
>    802.3z negotiation modes.
> 
> In all three cases, we ensure that state->link is false, just in case
> any MAC drivers have other ideas by mis-using this member, and we also
> take account of manual pause mode configuration at this point.
> 
> This avoids MLO_PAUSE_AN being seen in mac_config() when operating in
> PHY, fixed mode or inband SGMII mode, thereby giving cleaner semantics
> to the pause flags.  As a result of this, the pause flags now indicate
> in a mode-independent way what is required from a mac_config()
> implementation.
> 
> Signed-off-by: Russell King <rmk+kernel@...linux.org.uk>

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew