netdev - RE: [PATCH v2] vsock.7: add VMADDR_CID

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <MWHPR05MB3376C52124D5BB1835CC3362DA160@MWHPR05MB3376.namprd05.prod.outlook.com>
Date:   Mon, 17 Feb 2020 13:55:58 +0000
From:   Jorgen Hansen <jhansen@...are.com>
To:     'Stefano Garzarella' <sgarzare@...hat.com>,
        "mtk.manpages@...il.com" <mtk.manpages@...il.com>
CC:     "linux-man@...r.kernel.org" <linux-man@...r.kernel.org>,
        Stefan Hajnoczi <stefanha@...hat.com>,
        Dexuan Cui <decui@...rosoft.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: RE: [PATCH v2] vsock.7: add VMADDR_CID_LOCAL description

> From: Stefano Garzarella [mailto:sgarzare@...hat.com]
> Sent: Friday, February 14, 2020 2:08 PM
> To: mtk.manpages@...il.com
> Cc: Jorgen Hansen <jhansen@...are.com>; linux-man@...r.kernel.org;
> Stefan Hajnoczi <stefanha@...hat.com>; Dexuan Cui
> <decui@...rosoft.com>; netdev@...r.kernel.org
> Subject: [PATCH v2] vsock.7: add VMADDR_CID_LOCAL description
> 
> Linux 5.6 added the new well-known VMADDR_CID_LOCAL for local
> communication.
> 
> This patch explains how to use it and remove the legacy
> VMADDR_CID_RESERVED no longer available.
> 
> Signed-off-by: Stefano Garzarella <sgarzare@...hat.com>
> ---
> v2:
>     * rephrased "Local communication" description [Stefan]
>     * added a mention of previous versions that supported
>       loopback only in the guest [Stefan]
> ---


> @@ -222,6 +232,11 @@ are valid.
>  Support for VMware (VMCI) has been available since Linux 3.9.
>  KVM (virtio) is supported since Linux 4.8.
>  Hyper-V is supported since Linux 4.14.
> +.PP
> +VMADDR_CID_LOCAL is supported since Linux 5.6.
> +Local communication in the guest and on the host is available since Linux
> 5.6.
> +Previous versions partially supported it only in the guest and only
> +with some transports (VMCI and virtio).

Maybe rephrase the last part slightly to something like:

Previous versions only supported local communication within a guest (not on the host),
and only with some transports (VMCI and virtio).

Otherwise, looks good to me. Thanks for making this update.

Reviewed-by: Jorgen Hansen <jhansen@...are.com>