netdev - Re: [PATCH net] net: rtnetlink: fix bugs in rtnl_alt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200216.185313.2089845162456995802.davem@davemloft.net>
Date:   Sun, 16 Feb 2020 18:53:13 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     edumazet@...gle.com
Cc:     netdev@...r.kernel.org, eric.dumazet@...il.com, jiri@...lanox.com,
        syzkaller@...glegroups.com
Subject: Re: [PATCH net] net: rtnetlink: fix bugs in rtnl_alt_ifname()

From: Eric Dumazet <edumazet@...gle.com>
Date: Wed, 12 Feb 2020 20:58:26 -0800

> Since IFLA_ALT_IFNAME is an NLA_STRING, we have no
> guarantee it is nul terminated.
> 
> We should use nla_strdup() instead of kstrdup(), since this
> helper will make sure not accessing out-of-bounds data.
 ...
> Fixes: 36fbf1e52bd3 ("net: rtnetlink: add linkprop commands to add and delete alternative ifnames")
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Cc: Jiri Pirko <jiri@...lanox.com>
> Reported-by: syzbot <syzkaller@...glegroups.com>

Applied and queued up for -stable.