netdev - Re: [PATCH] bpf_prog_offload_info_fill: replace bitwise AND by logical AND

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5456d0d1-487d-1019-3083-397803b23888@iogearbox.net>
Date:   Mon, 17 Feb 2020 16:56:57 +0100
From:   Daniel Borkmann <daniel@...earbox.net>
To:     Johannes Krude <johannes@...de.de>, bpf@...r.kernel.org,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Cc:     "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <jakub.kicinski@...ronome.com>,
        trivial@...nel.org
Subject: Re: [PATCH] bpf_prog_offload_info_fill: replace bitwise AND by
 logical AND

On 2/12/20 8:32 PM, Johannes Krude wrote:
> This if guards whether user-space wants a copy of the offload-jited
> bytecode and whether this bytecode exists. By erroneously doing a bitwise
> AND instead of a logical AND on user- and kernel-space buffer-size can lead
> to no data being copied to user-space especially when user-space size is a
> power of two and bigger then the kernel-space buffer.
> 
> Signed-off-by: Johannes Krude <johannes@...de.de>

Applied, thanks!