netdev - Re: [PATCH net] net: add strict checks in netdev_name_node_alt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200216.190518.584096983278979522.davem@davemloft.net>
Date:   Sun, 16 Feb 2020 19:05:18 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     edumazet@...gle.com
Cc:     netdev@...r.kernel.org, eric.dumazet@...il.com,
        syzkaller@...glegroups.com, jiri@...lanox.com
Subject: Re: [PATCH net] net: add strict checks in
 netdev_name_node_alt_destroy()

From: Eric Dumazet <edumazet@...gle.com>
Date: Fri, 14 Feb 2020 07:53:53 -0800

> netdev_name_node_alt_destroy() does a lookup over all
> device names of a namespace.
> 
> We need to make sure the name belongs to the device
> of interest, and that we do not destroy its primary
> name, since we rely on it being not deleted :
> dev->name_node would indeed point to freed memory.
> 
> syzbot report was the following :
 ...
> Fixes: 36fbf1e52bd3 ("net: rtnetlink: add linkprop commands to add and delete alternative ifnames")
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Reported-by: syzbot <syzkaller@...glegroups.com>

Applied and queued up for -stable.