netdev - Re: [PATCH net-next 4/5] net: mvneta: introduce xdp counters to ethtool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20200217.141850.2134390863127670308.davem@davemloft.net>
Date:   Mon, 17 Feb 2020 14:18:50 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     lorenzo.bianconi@...hat.com
Cc:     brouer@...hat.com, lorenzo@...nel.org, netdev@...r.kernel.org,
        ilias.apalodimas@...aro.org, dsahern@...nel.org,
        bpf@...r.kernel.org
Subject: Re: [PATCH net-next 4/5] net: mvneta: introduce xdp counters to
 ethtool

From: Lorenzo Bianconi <lorenzo.bianconi@...hat.com>
Date: Mon, 17 Feb 2020 11:25:50 +0100

> yes, I think it is definitely better. So to follow up:
> - rename current "xdp_tx" counter in "xdp_xmit" and increment it for
>   XDP_TX verdict and for ndo_xdp_xmit
> - introduce a new "xdp_tx" counter only for XDP_TX verdict.
> 
> If we agree I can post a follow-up patch.

What names do other drivers use?  Consistency is important.  I noticed
while reviewing these patches that mellanox drivers export similar
statistics in the exact same way.