netdev - Re: [PATCH net] mptcp: fix bogus socket flag values

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200217.145237.25836634449905721.davem@davemloft.net>
Date:   Mon, 17 Feb 2020 14:52:37 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     fw@...len.de
Cc:     netdev@...r.kernel.org, dan.carpenter@...cle.com
Subject: Re: [PATCH net] mptcp: fix bogus socket flag values

From: Florian Westphal <fw@...len.de>
Date: Mon, 17 Feb 2020 16:54:38 +0100

> Dan Carpenter reports static checker warnings due to bogus BIT() usage:
> 
> net/mptcp/subflow.c:571 subflow_write_space() warn: test_bit() takes a bit number
> net/mptcp/subflow.c:694 subflow_state_change() warn: test_bit() takes a bit number
> net/mptcp/protocol.c:261 ssk_check_wmem() warn: test_bit() takes a bit number
> [..]
> 
> This is harmless (we use bits 1 & 2 instead of 0 and 1), but would
> break eventually when adding BIT(5) (or 6, depends on size of 'long').
> 
> Just use 0 and 1, the values are only passed to test/set/clear_bit
> functions.
> 
> Fixes: 648ef4b88673 ("mptcp: Implement MPTCP receive path")
> Reported-by: Dan Carpenter <dan.carpenter@...cle.com>
> Signed-off-by: Florian Westphal <fw@...len.de>

Applied, thanks Florian.