netdev - Re: [PATCH net] mptcp: select CRYPTO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200216.193732.474649064358030475.davem@davemloft.net>
Date:   Sun, 16 Feb 2020 19:37:32 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     matthieu.baerts@...sares.net
Cc:     netdev@...r.kernel.org, mathew.j.martineau@...ux.intel.com,
        pabeni@...hat.com, cpaasch@...le.com, mptcp@...ts.01.org
Subject: Re: [PATCH net] mptcp: select CRYPTO

From: Matthieu Baerts <matthieu.baerts@...sares.net>
Date: Sat, 15 Feb 2020 15:45:56 +0100

> Without this modification and if CRYPTO is not selected, we have this
> warning:
> 
>   WARNING: unmet direct dependencies detected for CRYPTO_LIB_SHA256
>     Depends on [n]: CRYPTO [=n]
>     Selected by [y]:
>     - MPTCP [=y] && NET [=y] && INET [=y]
> 
> MPTCP selects CRYPTO_LIB_SHA256 which seems to depend on CRYPTO. CRYPTO
> is now selected to avoid this issue.
> 
> Even though the config system prints that warning, it looks like
> sha256.c is compiled and linked even without CONFIG_CRYPTO. Since MPTCP
> will end up needing CONFIG_CRYPTO anyway in future commits -- currently
> in preparation for net-next -- we propose to add it now to fix the
> warning.
> 
> The dependency in the config system comes from the fact that
> CRYPTO_LIB_SHA256 is defined in "lib/crypto/Kconfig" which is sourced
> from "crypto/Kconfig" only if CRYPTO is selected.
> 
> Fixes: 65492c5a6ab5 (mptcp: move from sha1 (v0) to sha256 (v1))
> Signed-off-by: Matthieu Baerts <matthieu.baerts@...sares.net>

Applied.