netdev - Re: [PATCH] net: ethernet: dm9000: Handle -EPROBE_DEFER in dm9000_parse

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1513E253-0E58-4088-84E2-E35F3067BB4B@goldelico.com>
Date:   Mon, 17 Feb 2020 11:04:35 +0100
From:   "H. Nikolaus Schaller" <hns@...delico.com>
To:     Paul Cercueil <paul@...pouillou.net>
Cc:     "David S . Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, Mathieu Malaterre <malat@...ian.org>
Subject: Re: [PATCH] net: ethernet: dm9000: Handle -EPROBE_DEFER in dm9000_parse_dt()

Hi Paul,

> Am 16.02.2020 um 20:39 schrieb Paul Cercueil <paul@...pouillou.net>:
> 
> The call to of_get_mac_address() can return -EPROBE_DEFER, for instance
> when the MAC address is read from a NVMEM driver that did not probe yet.

a quick test on the CI20 board shows that it seems to work. Especially
in this config, which would be broken otherwise:

CONFIG_JZ4780_EFUSE=m
CONFIG_DM9000=y

The other way round is not expected to be a problem.

It also serializes

CONFIG_JZ4780_EFUSE=m
CONFIG_DM9000=m

properly.

What I am not sure is if it handles

CONFIG_JZ4780_EFUSE=y
CONFIG_DM9000=y

always correct.

Is the EPROBE_DEFER mechanism also working for drivers
fully compiled into the kernel (I may have been mislead
since EPROBE_DEFER patches are almost always done to make
drivers work as modules)?

If not, it depends on luck to have the EFUSE driver probed
successfully before DM9000.

Anyways you can add my Tested-by: H. Nikolaus Schaller <hns@...delico.com>

BR and thanks,
Nikolaus

> 
> Cc: H. Nikolaus Schaller <hns@...delico.com>
> Cc: Mathieu Malaterre <malat@...ian.org>
> Signed-off-by: Paul Cercueil <paul@...pouillou.net>
> ---
> drivers/net/ethernet/davicom/dm9000.c | 2 ++
> 1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/net/ethernet/davicom/dm9000.c b/drivers/net/ethernet/davicom/dm9000.c
> index 1ea3372775e6..e94ae9b94dbf 100644
> --- a/drivers/net/ethernet/davicom/dm9000.c
> +++ b/drivers/net/ethernet/davicom/dm9000.c
> @@ -1405,6 +1405,8 @@ static struct dm9000_plat_data *dm9000_parse_dt(struct device *dev)
> 	mac_addr = of_get_mac_address(np);
> 	if (!IS_ERR(mac_addr))
> 		ether_addr_copy(pdata->dev_addr, mac_addr);
> +	else if (PTR_ERR(mac_addr) == -EPROBE_DEFER)
> +		return ERR_CAST(mac_addr);
> 
> 	return pdata;
> }
> -- 
> 2.25.0
>