netdev - Re: [PATCH 8/8] net: ll_temac: Add ethtool support for coalesce parameters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87v9o4gebm.fsf@geanix.com>
Date:   Tue, 18 Feb 2020 15:28:13 +0100
From:   Esben Haabendal <esben@...nix.com>
To:     Andrew Lunn <andrew@...n.ch>
Cc:     netdev@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org,
        "David S . Miller" <davem@...emloft.net>,
        Michal Simek <michal.simek@...inx.com>,
        Petr Štetiar <ynezz@...e.cz>
Subject: Re: [PATCH 8/8] net: ll_temac: Add ethtool support for coalesce parameters

Andrew Lunn <andrew@...n.ch> writes:

> Hi Esben
>
>> +	if (ec->tx_coalesce_usecs)
>> +		lp->coalesce_delay_tx =
>> +			min(255U, (ec->tx_coalesce_usecs * 100) / 512);
>> +
>> +	pr_info("%d -> %d  %d -> %d\n",
>> +		ec->rx_coalesce_usecs, lp->coalesce_delay_rx,
>> +		ec->tx_coalesce_usecs, lp->coalesce_delay_tx);
>
> I guess this is left over from debug? You don't actually want it here?

Yes, I will remove that in v2.  Thanks.

/Esben