netdev - Re: [PATCH v2 net-next] net: fec: Prevent unbind operation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 18 Feb 2020 12:30:39 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     festevam@...il.com
Cc:     fugang.duan@....com, netdev@...r.kernel.org
Subject: Re: [PATCH v2 net-next] net: fec: Prevent unbind operation

From: Fabio Estevam <festevam@...il.com>
Date: Tue, 18 Feb 2020 12:34:44 -0300

> After performing an unbind/bind operation the network is no longer
> functional on i.MX6 (which has a single FEC instance):
> 
> # echo 2188000.ethernet > /sys/bus/platform/drivers/fec/unbind
> # echo 2188000.ethernet > /sys/bus/platform/drivers/fec/bind
> [   10.756519] pps pps0: new PPS source ptp0
> [   10.792626] libphy: fec_enet_mii_bus: probed
> [   10.799330] fec 2188000.ethernet eth0: registered PHC device 1
> # udhcpc -i eth0
> udhcpc: started, v1.31.1
> [   14.985211] fec 2188000.ethernet eth0: no PHY, assuming direct connection to switch
> [   14.993140] libphy: PHY fixed-0:00 not found
> [   14.997643] fec 2188000.ethernet eth0: could not attach to PHY
> 
> On SoCs with two FEC instances there are some cases where one FEC instance
> depends on the other one being present. One such example is i.MX28, which
> has the following FEC dependency as noted in the comments:
 ...
> Prevent the unbind operation to avoid these issues.
> 
> Signed-off-by: Fabio Estevam <festevam@...il.com>

Applied, thanks.