netdev - RE: [RFC PATCH v4 18/25] RDMA/irdma: Implement device supported verb APIs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 18 Feb 2020 20:43:17 +0000
From:   "Saleem, Shiraz" <shiraz.saleem@...el.com>
To:     Jason Gunthorpe <jgg@...pe.ca>,
        "Kirsher, Jeffrey T" <jeffrey.t.kirsher@...el.com>
CC:     "davem@...emloft.net" <davem@...emloft.net>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "Ismail, Mustafa" <mustafa.ismail@...el.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>,
        "nhorman@...hat.com" <nhorman@...hat.com>,
        "sassmann@...hat.com" <sassmann@...hat.com>
Subject: RE: [RFC PATCH v4 18/25] RDMA/irdma: Implement device supported
 verb APIs

> Subject: Re: [RFC PATCH v4 18/25] RDMA/irdma: Implement device supported
> verb APIs
> 
> On Wed, Feb 12, 2020 at 11:14:17AM -0800, Jeff Kirsher wrote:
> 
> > +/**
> > + * irdma_ib_register_device - register irdma device to IB core
> > + * @iwdev: irdma device
> > + */
> > +int irdma_ib_register_device(struct irdma_device *iwdev) {
> > +	int ret;
> > +
> > +	ret = irdma_init_rdma_device(iwdev);
> > +	if (ret)
> > +		return ret;
> > +
> > +	rdma_set_device_sysfs_group(&iwdev->ibdev, &irdma_attr_group);
> 
> New drivers are forbidden from calling this:
> 
OK. Agreed. What's exported via query device suffices.