netdev - Re: [Patch nf] netfilter: xt_hashlimit: unregister proc file before releasing mutex

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200218213524.5yuccwnl2eie6p6x@salvia>
Date:   Tue, 18 Feb 2020 22:35:24 +0100
From:   Pablo Neira Ayuso <pablo@...filter.org>
To:     Cong Wang <xiyou.wangcong@...il.com>
Cc:     netdev@...r.kernel.org, fw@...len.de,
        netfilter-devel@...r.kernel.org,
        syzbot+d195fd3b9a364ddd6731@...kaller.appspotmail.com
Subject: Re: [Patch nf] netfilter: xt_hashlimit: unregister proc file before
 releasing mutex

On Wed, Feb 12, 2020 at 10:53:52PM -0800, Cong Wang wrote:
> Before releasing the global mutex, we only unlink the hashtable
> from the hash list, its proc file is still not unregistered at
> this point. So syzbot could trigger a race condition where a
> parallel htable_create() could register the same file immediately
> after the mutex is released.
> 
> Move htable_remove_proc_entry() back to mutex protection to
> fix this. And, fold htable_destroy() into htable_put() to make
> the code slightly easier to understand.

Probably revert previous one?