netdev - Re: [PATCH net-next v2 08/13] ionic: use new helper tcp_v6_gso_csum

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b542e139-307b-47eb-cdf8-45465e8e7b41@pensando.io>
Date:   Tue, 18 Feb 2020 14:56:40 -0800
From:   Shannon Nelson <snelson@...sando.io>
To:     Heiner Kallweit <hkallweit1@...il.com>,
        David Miller <davem@...emloft.net>,
        Pensando Drivers <drivers@...sando.io>
Cc:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net-next v2 08/13] ionic: use new helper
 tcp_v6_gso_csum_prep

On 2/18/20 12:07 PM, Heiner Kallweit wrote:
> Use new helper tcp_v6_gso_csum_prep in additional network drivers.
>
> Signed-off-by: Heiner Kallweit <hkallweit1@...il.com>

Acked-by: Shannon Nelson <snelson@...sando.io>

> ---
>   drivers/net/ethernet/pensando/ionic/ionic_txrx.c | 5 +----
>   1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/net/ethernet/pensando/ionic/ionic_txrx.c b/drivers/net/ethernet/pensando/ionic/ionic_txrx.c
> index e452f4242..020acc300 100644
> --- a/drivers/net/ethernet/pensando/ionic/ionic_txrx.c
> +++ b/drivers/net/ethernet/pensando/ionic/ionic_txrx.c
> @@ -632,10 +632,7 @@ static int ionic_tx_tcp_pseudo_csum(struct sk_buff *skb)
>   					   ip_hdr(skb)->daddr,
>   					   0, IPPROTO_TCP, 0);
>   	} else if (skb->protocol == cpu_to_be16(ETH_P_IPV6)) {
> -		tcp_hdr(skb)->check =
> -			~csum_ipv6_magic(&ipv6_hdr(skb)->saddr,
> -					 &ipv6_hdr(skb)->daddr,
> -					 0, IPPROTO_TCP, 0);
> +		tcp_v6_gso_csum_prep(skb);
>   	}
>   
>   	return 0;