netdev - Re: [RFC net-next] net: mvneta: align xdp stats naming scheme to mlx5 driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c9018a2d-27d0-9ff8-82eb-83b37b40b12f@gmail.com>
Date:   Tue, 18 Feb 2020 16:24:13 -0700
From:   David Ahern <dsahern@...il.com>
To:     Daniel Borkmann <daniel@...earbox.net>,
        Toke Høiland-Jørgensen <toke@...hat.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Lorenzo Bianconi <lorenzo@...nel.org>
Cc:     netdev@...r.kernel.org, ilias.apalodimas@...aro.org,
        davem@...emloft.net, lorenzo.bianconi@...hat.com, andrew@...n.ch,
        brouer@...hat.com, dsahern@...nel.org, bpf@...r.kernel.org
Subject: Re: [RFC net-next] net: mvneta: align xdp stats naming scheme to mlx5
 driver

On 2/18/20 4:19 PM, Daniel Borkmann wrote:
> On 2/18/20 11:23 PM, Toke Høiland-Jørgensen wrote:
>> Jakub Kicinski <kuba@...nel.org> writes:
>>> On Tue, 18 Feb 2020 01:14:29 +0100 Lorenzo Bianconi wrote:
>>>> Introduce "rx" prefix in the name scheme for xdp counters
>>>> on rx path.
>>>> Differentiate between XDP_TX and ndo_xdp_xmit counters
>>>>
>>>> Signed-off-by: Lorenzo Bianconi <lorenzo@...nel.org>
>>>
>>> Sorry for coming in late.
>>>
>>> I thought the ability to attach a BPF program to a fexit of another BPF
>>> program will put an end to these unnecessary statistics. IOW I maintain
>>> my position that there should be no ethtool stats for XDP.
>>>
>>> As discussed before real life BPF progs will maintain their own stats
>>> at the granularity of their choosing, so we're just wasting datapath
>>> cycles.
> 
> +1

There is value in having something as essential as stats available
through standard APIs and tooling. mlx5, i40e, sfc, etc, etc already
provide stats via ethtool. This patch is making mvneta consistent with
existing stats from these other drivers.