netdev - Re: [PATCH 3/3] ag71xx: Run ag71xx_link

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20200217.215138.30487653437477925.davem@davemloft.net>
Date:   Mon, 17 Feb 2020 21:51:38 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     hauke@...ke-m.de
Cc:     linux@...pel-privat.de, netdev@...r.kernel.org, jcliburn@...il.com,
        chris.snook@...il.com
Subject: Re: [PATCH 3/3] ag71xx: Run ag71xx_link_adjust() only when needed

From: Hauke Mehrtens <hauke@...ke-m.de>
Date: Tue, 18 Feb 2020 00:35:18 +0100

> +		if (ag->duplex != phydev->duplex ||
> +		    ag->speed != phydev->speed) {
> +			status_change = 1;
> +		}

A single statement basic block should not be enclosed in curly
braces.

Thank you.