netdev - Re: [PATCH net-next] net: ena: remove set but not used variable 'hash

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200217.223320.1107717283396960655.davem@davemloft.net>
Date:   Mon, 17 Feb 2020 22:33:20 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     yuehaibing@...wei.com
Cc:     netanel@...zon.com, akiyano@...zon.com, gtzalik@...zon.com,
        saeedb@...zon.com, zorik@...zon.com, sameehj@...zon.com,
        kuba@...nel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next] net: ena: remove set but not used variable
 'hash_key'

From: YueHaibing <yuehaibing@...wei.com>
Date: Tue, 18 Feb 2020 14:21:54 +0800

> drivers/net/ethernet/amazon/ena/ena_com.c: In function ena_com_hash_key_allocate:
> drivers/net/ethernet/amazon/ena/ena_com.c:1070:50:
>  warning: variable hash_key set but not used [-Wunused-but-set-variable]
> 
> commit 6a4f7dc82d1e ("net: ena: rss: do not allocate key when not supported")
> introduced this, but not used, so remove it.
> 
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>

Applied.